Allow building of the ufs-weather-model, WW3 pre/post execs for GFS, GEFS, SFS in the same clone of global-workflow #3098
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
aerorahul
changed the title
|
I am going to mark this as ready for review to gather feedback on the code changes before I commence extensive testing. |
aerorahul
requested review from
JessicaMeixner-NOAA,
sbanihash,
WalterKolczynski-NOAA,
DavidHuber-NOAA,
KateFriedman-NOAA and
TerrenceMcGuinness-NOAA
as code owners
WalterKolczynski-NOAA
added
the
CI-Wcoss2-Failed
|
Digging in, I find a couple different things. The ww3_grib error seems to come an inability to open a file ( There is a zero-size There is also a failure in wave_grib_interp_sbs because it is trying to write to fix, which I think is supposed to be the source of the This doesn't immediately fail, but continues until the
The logs don't all get piped to STDOUT, so you have to root around in the DATA directory to find them (here's one: |
|
I'll also note the |
|
This fail is from PR 307 in my forked repo for testing this build using the updated CI pipline: running the C48mx500_hybAOWCDA FAILED on Hercules in Build# 6 with error logs: Follow link here to view the contents of the above file(s): (link) All the other CI tests are all languishing in the Priority queues on Hercules |
…s another bug that needs evaluation on the purpose of the logic. A FIXME tag has been added
@TerrenceMcGuinness-NOAA |
There was a problem hiding this comment.
The updates to the Jenkinsfile pipeline script look good. The try/catch on the scm checkout looks strong too. An initial test of the pipeline worked fine in a forked branch in the development project. When CM (@WalterKolczynski-NOAA) is ready we should launch a CI test directly in this PR using multiple labels.
WalterKolczynski-NOAA
added
CI-Wcoss2-Running
emcbot
added
CI-Hera-Building
|
Will run CI on Hercules as well once the PRs already running there have completed. |
emcbot
added
CI-Hera-Running
|
CI Passed on Hera in Build# 1 |
WalterKolczynski-NOAA
added
the
CI-Hercules-Ready
emcbot
added
CI-Hercules-Building
emcbot
added
CI-Hercules-Running
Description
GFS and GEFS (and now SFS) uses different compile time options for the UFS-weather-model. For the purposes of CI testing, a multi-build pipeline under Jenkins was created by @TerrenceMcGuinness-NOAA. This served well, until now. With the inclusion of SFS, a third variety of the model is being built. Under the multi-build pipeline paradigm, a second (or third) clone and build of the global-workflow is required. This adds cloning and compilation time of the global-workflow.
This PR allows compiling the ufs-weather-model in a single clone of the global-workflow. The compiled executables based on the options for GFS, GEFS, and SFS results in a model executable as
gfs_model.x,gefs_model.x, andsfs_model.x. The forecast script uses the right executable.This PR also differentiates the WW3 pre/post executables based on
gfs_orgefs_. SFS variants need to be introduced, whenNET=sfsis added.In the process of updating the WW3 pre/post executable names, it was discovered (via
grep) the following are not used:ww3_prepww3_outfww3_ounfww3_ounpThese need to be confirmed by running the workflow to ensure they are indeed not used at runtime.
This PR also updates the
Jenkinsfileto use the multi-build from the single location.Type of change
Change characteristics
This PR does not update any submodules.
How has this been tested?
In progress
Checklist